Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTTP method used for rotating Client secret #191

Merged
merged 1 commit into from
May 2, 2019
Merged

Fix HTTP method used for rotating Client secret #191

merged 1 commit into from
May 2, 2019

Conversation

lbalmaceda
Copy link
Contributor

@lbalmaceda lbalmaceda commented May 2, 2019 •
edited
Loading

Changes

The rotate client secret endpoint expects a POST request, not a GET. This PR fixes it.

References

Will close #189

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@lbalmaceda lbalmaceda changed the title Fix wrong HTTP method being used for rotating client secret Fix HTTP method used for rotating Client secret May 2, 2019
@lbalmaceda lbalmaceda added this to the v3-Next milestone May 2, 2019
@lbalmaceda lbalmaceda merged commit c666de8 into master May 2, 2019
@lbalmaceda lbalmaceda deleted the fix-rotate-secret branch May 2, 2019 20:25
@lbalmaceda lbalmaceda modified the milestones: v3-Next, 3.7.2 May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcanhelp joshcanhelp joshcanhelp approved these changes

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
3.7.2
Development

Successfully merging this pull request may close these issues.

rotate_secret should be a POST
2 participants
@lbalmaceda @joshcanhelp