Implemented delete_user_by_email and test for connections #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
suggested changes
Oct 3, 2018
There was a problem hiding this comment.
Thanks @runz0rd! A couple of very minor docs changes then I'll approve 👍
auth0/v3/management/connections.py
Outdated
| @@ -116,3 +116,17 @@ def create(self, body): | |||
| """ | |||
|
|
|||
| return self.client.post(self._url(), data=body) | |||
|
|
|||
| def delete_user_by_email(self, id, email): | |||
| """Deletes a specified connection user by its email | |||
There was a problem hiding this comment.
Add a period at the end.
auth0/v3/management/connections.py
Outdated
| """Deletes a specified connection user by its email | ||
|
|
||
| Args: | ||
| id (str): Id of the connection. |
There was a problem hiding this comment.
Consider from our docs:
The id of the connection (must be a database connection).
auth0/v3/management/connections.py
Outdated
| Args: | ||
| id (str): Id of the connection. | ||
|
|
||
| email (str): The email of the user to delete |
There was a problem hiding this comment.
Add a period at the end.
joshcanhelp
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #121