Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default value for search_engine #185

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Conversation

lbalmaceda
Copy link
Contributor

Changes

Search engine v2 is no longer available for new tenants. This caused frustration for those using this library without passing a specific value for the search_engine feature when querying for users.

This PR removes the default value of v1 (even older, and already disabled a long time ago). This way, those not specifying a value will default to the backend's latest version. Currently v3.

Those already passing a fixed value will see no effect.

References

User search v2 has been deprecated as of June 6th 2018. Tenants created after this date will not have the option of using it. We recommend that you use User Search v3 instead.

https://auth0.com/docs/users/search/v2
https://auth0.com/docs/users/search/v3

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@lbalmaceda lbalmaceda added this to the v3-Next milestone Apr 4, 2019
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lbalmaceda lbalmaceda merged commit 533018b into master Apr 4, 2019
@lbalmaceda lbalmaceda deleted the rm-search-engine branch April 4, 2019 15:34
@lbalmaceda lbalmaceda modified the milestones: v3-Next, 3.7.0 Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants