Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new user method invalidate_remembered_browsers #248

Merged

Conversation

kpurdon
Copy link
Contributor

@kpurdon kpurdon commented Nov 25, 2020

Changes

Please describe both what is changing and why this is important. Include:

  • Adds a missing endpoint to invalidate all remembered browsers (mfa) for a user

References

https://auth0.com/docs/api/management/v2#!/Users/post_invalidate_remember_browser

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@kpurdon kpurdon requested a review from a team as a code owner November 25, 2020 23:00
@kpurdon kpurdon force-pushed the kpurdon/add-user-invalidate-remember-browsers branch 2 times, most recently from 639a313 to fe13b67 Compare November 25, 2020 23:05
@kpurdon kpurdon force-pushed the kpurdon/add-user-invalidate-remember-browsers branch from fe13b67 to 241f6fe Compare November 25, 2020 23:09
@kpurdon
Copy link
Contributor Author

kpurdon commented Dec 2, 2020

@lbalmaceda from issues it looks like your the correct person to check in with on this (LMK if that's not the case). Anything I can do to get this reviewed? Thanks!

Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one minor request around the value used as input in the tests.

auth0/v3/test/management/test_users.py Outdated Show resolved Hide resolved
auth0/v3/test/management/test_users.py Outdated Show resolved Hide resolved
@lbalmaceda lbalmaceda added this to the v3-Next milestone Dec 22, 2020
@lbalmaceda lbalmaceda added the small Small review label Dec 22, 2020
@lbalmaceda lbalmaceda merged commit e1adcbe into auth0:master Dec 22, 2020
@lbalmaceda lbalmaceda modified the milestones: v3-Next, 3.14.0 Dec 22, 2020
@kpurdon kpurdon deleted the kpurdon/add-user-invalidate-remember-browsers branch December 22, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Added small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants