Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair Organisation get by name URL. #269

Merged

Conversation

queenvictoria
Copy link
Contributor

@queenvictoria queenvictoria commented Apr 19, 2021

Changes

Please describe both what is changing and why this is important. Include:

  • Endpoints added, deleted, deprecated, or changed
    There is an error in organizations.get_organization_by_name. The path from the docs should be /api/v2/organizations/name/{name}. The current implementation, however, just uses the default /api/v2/organizations and sends the name parameter (which is invalid and throws an error).

References

Please include relevant links supporting this change such as a:

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language or why not

I'm sorry but I can't see how to run the existing test. Please point me to the instructions and I'll update the PR.

Checklist

@queenvictoria queenvictoria requested a review from a team as a code owner April 19, 2021 02:00
@lbalmaceda lbalmaceda merged commit 0f82f78 into auth0:master Apr 19, 2021
@lbalmaceda lbalmaceda added this to the v3-Next milestone Apr 19, 2021
@lbalmaceda
Copy link
Contributor

Thanks for catching this!

@lbalmaceda lbalmaceda modified the milestones: v3-Next, 3.17.0 Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants