Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to device credentials #300

Merged

Conversation

fionnulak
Copy link
Contributor

Changes

Please describe both what is changing and why this is important. Include:

Added two pagination parameters to the /v3/management/device-credentials get method.

References

This is in relation to #299

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage

Checklist

@fionnulak fionnulak requested a review from a team as a code owner January 4, 2022 14:40
Copy link
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! We should add support for the pagination params to the device credentials GET method. However, I think as currently implemented in this PR, it could be a breaking change for existing function calls using positional parameters.

auth0/v3/management/device_credentials.py Outdated Show resolved Hide resolved
@fionnulak fionnulak force-pushed the add-pagination-to-device-credentials branch from 55c0e88 to 0ac5b38 Compare January 12, 2022 10:10
@jimmyjames jimmyjames added this to the v3-Next milestone Jan 18, 2022
jimmyjames
jimmyjames previously approved these changes Jan 18, 2022
@jimmyjames jimmyjames merged commit 9d6e526 into auth0:master Feb 18, 2022
@adamjmcgrath adamjmcgrath mentioned this pull request Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants