Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry all methods on 429 #518

Merged
merged 7 commits into from
Oct 24, 2023
Merged

Retry all methods on 429 #518

merged 7 commits into from
Oct 24, 2023

Conversation

adamjmcgrath
Copy link
Contributor

Changes

Currently the SDK only retries on 429s in a GET, add retry to the other methods

References

fixes #513

@adamjmcgrath adamjmcgrath requested a review from a team as a code owner August 25, 2023 15:21
@adamjmcgrath adamjmcgrath temporarily deployed to internal August 25, 2023 15:21 — with GitHub Actions Inactive
@adamjmcgrath adamjmcgrath temporarily deployed to internal August 25, 2023 15:21 — with GitHub Actions Inactive
@adamjmcgrath adamjmcgrath temporarily deployed to internal August 30, 2023 13:33 — with GitHub Actions Inactive
@adamjmcgrath adamjmcgrath temporarily deployed to internal August 30, 2023 13:33 — with GitHub Actions Inactive
@adamjmcgrath adamjmcgrath temporarily deployed to internal August 30, 2023 13:33 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal October 11, 2023 09:55 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal October 11, 2023 09:55 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal October 11, 2023 09:55 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal October 23, 2023 15:44 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal October 23, 2023 15:44 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal October 23, 2023 15:44 — with GitHub Actions Inactive
Copy link
Member

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adamjmcgrath adamjmcgrath added this pull request to the merge queue Oct 24, 2023
Merged via the queue into master with commit 82b3e1c Oct 24, 2023
15 checks passed
@adamjmcgrath adamjmcgrath deleted the retry-all-methods branch October 24, 2023 12:05
@adamjmcgrath adamjmcgrath mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retries implementation of rest.py missing for POST/PATCH/PUT/DELETE
3 participants