Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move withAuthenticationRequired HOC out of render #385

Merged
merged 1 commit into from Jul 21, 2022
Merged

Move withAuthenticationRequired HOC out of render #385

merged 1 commit into from Jul 21, 2022

Conversation

adamjmcgrath
Copy link
Member

Description

Move withAuthenticationRequired Higher Order Component outside of the render path in the React Router example app.

References

See: https://reactjs.org/docs/higher-order-components.html#dont-use-hocs-inside-the-render-method
See: #382

@adamjmcgrath adamjmcgrath added the review:small Small review label Jul 21, 2022
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner July 21, 2022 09:53
@Widcket Widcket merged commit 809922b into master Jul 21, 2022
@Widcket Widcket deleted the move-hoc branch July 21, 2022 13:15
@adamjmcgrath adamjmcgrath mentioned this pull request Jul 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
review:small Small review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamjmcgrath @Widcket