Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useUnknownInCatchVariables to be compliant with TS ^4.4 #511

Merged
merged 2 commits into from Mar 14, 2023

Conversation

cemercier
Copy link
Contributor

@cemercier cemercier commented Feb 20, 2023

Description

Projects that use typescript in strict mode with a version > 4.4 cannot compile unless they use the useUnknownInCatchVariables: false flag (#319).

References

Original issue: #302
Typescript changelog: https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#using-unknown-in-catch-variables

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • The correct base branch is being used, if not the default branch
  • All active GitHub checks for tests, formatting, and security are passing

@cemercier cemercier requested a review from a team as a code owner February 20, 2023 16:39
Copy link
Contributor

@adamjmcgrath adamjmcgrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cemercier!

@adamjmcgrath adamjmcgrath merged commit ee0f618 into auth0:master Mar 14, 2023
@cemercier
Copy link
Contributor Author

Hello @adamjmcgrath , do you know when the next release is planned ? We are quite stuck because of this.

@adamjmcgrath
Copy link
Contributor

Hi @cemercier - I'll do a release today

@adamjmcgrath adamjmcgrath mentioned this pull request Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants