Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding onBeforeAuthentication to the withAuthenticationRequired HOC #534

Merged
merged 2 commits into from May 5, 2023

Conversation

stephenkelzer
Copy link
Contributor

@stephenkelzer stephenkelzer commented Apr 28, 2023

Description

Adds an optional onBeforeAuthentication function property to the withAuthenticationRequired HOC that is called before navigating to the Auth0 authentication screen from your application. This should not introduce any breaking changes as everything is optional (I used onRedirecting for inspiration during my implementation).

I am currently using Auth0's withAuthenticationRequired HOC and our product team wants to fire an event to our analytics provider when a user triggers the authentication process with Auth0.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@stephenkelzer stephenkelzer requested a review from a team as a code owner April 28, 2023 20:24
Copy link
Contributor

@adamjmcgrath adamjmcgrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamjmcgrath adamjmcgrath merged commit ba11472 into auth0:master May 5, 2023
3 checks passed
@adamjmcgrath adamjmcgrath mentioned this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants