Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sync openUrl #1087

Merged
merged 1 commit into from Mar 14, 2023
Merged

Allow sync openUrl #1087

merged 1 commit into from Mar 14, 2023

Conversation

adamjmcgrath
Copy link
Contributor

Changes

openUrl can be synchronous eg.

await auth0.logout({
  openUrl(url) {
    window.location.replace(url);
  }
});

References

fixes auth0/auth0-react#521

@adamjmcgrath adamjmcgrath added the review:tiny Tiny review label Mar 14, 2023
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner March 14, 2023 10:35
@frederikprijck frederikprijck enabled auto-merge (squash) March 14, 2023 10:39
@frederikprijck frederikprijck merged commit dc36d33 into master Mar 14, 2023
3 checks passed
@frederikprijck frederikprijck deleted the sync-open-url branch March 14, 2023 10:40
@frederikprijck frederikprijck mentioned this pull request May 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikprijck frederikprijck frederikprijck approved these changes

Assignees
No one assigned
Labels
review:tiny Tiny review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openUrl requires a returned promise, but why?
2 participants
@adamjmcgrath @frederikprijck