Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-1417] Customizable default scopes #435

Merged
merged 17 commits into from
Apr 30, 2020
Merged

[SDK-1417] Customizable default scopes #435

merged 17 commits into from
Apr 30, 2020

Commits on Apr 24, 2020

  1. Extracted changes needed to customize defaultScope

    @srihari93
    srihari93 authored and Steve Hobbs committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    61dc91c View commit details
    Browse the repository at this point in the history

  2. Moved existing defaultScopes test to the right place

    Steve Hobbs committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    4869386 View commit details
    Browse the repository at this point in the history

  3. getUniqueScopes moved into scope.ts

    Steve Hobbs committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    1e4b2ff View commit details
    Browse the repository at this point in the history

  4. Refactor getUniqueScopes into its own module 

    This allows it to me mocked or unmocked separately from utils.
index.test.ts has been completely refactored to use an unmocked version
and the expectations have changed as a result.
    Steve Hobbs committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    00b489c View commit details
    Browse the repository at this point in the history

  5. Stop mutating optios.scope and store in separate var

    Steve Hobbs committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    f8daf6a View commit details
    Browse the repository at this point in the history

  6. Added tests for relevant functions for using advanced default scopes

    Steve Hobbs committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    20fd45c View commit details
    Browse the repository at this point in the history

  7. Fix constructor after merge

    Steve Hobbs committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    6407a47 View commit details
    Browse the repository at this point in the history

  8. advancedOptions.defaultScope can accept empty/null value

    Steve Hobbs committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    dd21171 View commit details
    Browse the repository at this point in the history

  9. Added advanced section to readme 

    Docs build to follow in the release PR
    Steve Hobbs committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    158eaa4 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2020

  1. Merge branch 'master' into feature/advance-default-scope

    Steve Hobbs committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    a1fe4eb View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. Merge branch 'master' into feature/advance-default-scope

    Steve Hobbs committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    cce5d3c View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2020

  1. Set up proper spy for getUniqueScopes

    Steve Hobbs committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    9063ef0 View commit details
    Browse the repository at this point in the history

  2. Fixed types in JS docs

    Steve Hobbs committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    66def7d View commit details
    Browse the repository at this point in the history

  3. Simplified getUniqueScopes implementation

    Steve Hobbs committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    ae19992 View commit details
    Browse the repository at this point in the history

  4. Cleaned up index test file

    Steve Hobbs committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    19cc0db View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into feature/advance-default-scope

    Steve Hobbs committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    65ffa1e View commit details
    Browse the repository at this point in the history

  6. Simplified the defaultScope check using null chaining operator

    Steve Hobbs committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    503d440 View commit details
    Browse the repository at this point in the history