[SDK-1696] Allow caller of cache.get to specify an expiry time adjustment #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
changed the title
adamjmcgrath
requested changes
Jun 2, 2020
|
Lgtm, will fix #474 @JonathanHarvey could you see if you can repro #480 with this branch? |
added 2 commits
June 2, 2020 13:32
This allows: * Cache expires_at to be the same time as now() + expires_in (no longer includes an adjustment built in) * getTokenSilently can itself make a decision about whether to use the cached value, or refresh the token if expires_in - adjustment < now * functions like isAuthenticated to return `true` right up until the expires_in time is reached
stevehobbsdev
force-pushed
the
fix/gts-leeway
branch
from
f6f389b
to
a0652d0
Compare
stevehobbsdev
force-pushed
the
fix/gts-leeway
branch
from
a0652d0
to
e171fba
Compare
adamjmcgrath
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The adjustment value used on the expiry time from the cache can now be configured per call to
cache.get. The default is 0.This allows:
expires_atto be the same time asnow() + expires_in(no longer includes an adjustment built in)getTokenSilentlycan itself make a decision about whether to use the cached value, or refresh the token ifexpires_in - adjustment < nowisAuthenticatedto returntrueright up until theexpires_intime is reachedReferences
Fixes #480
Fixes #474
Testing
Checklist
master