[SDK-1699] Fix ID token validation for auth_time #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjmcgrath
reviewed
Jun 5, 2020
stevehobbsdev
force-pushed
the
fix/max-age-validation
branch
from
de00f89
to
8bded7a
Compare
adamjmcgrath
approved these changes
Jun 11, 2020
|
Hi team, any indication on when this fix will be incorporated into a new release? |
|
Hi @MrPrashantT, this is now available in the v1.10.0 release that was released yesterday. This was released to NPM yesterday but I've just tagged it now - thanks for the reminder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
auth_timeclaim was being incorrectly validated in milliseconds, where this should be seconds.References
Fixes #489
Testing
The relevant test was also incorrectly suppling test data in ms, so this has been updated. The test also only validated half of the validation message (the part which doesn't include the time), so this has been improved to correctly validate the entire string.
Checklist
master