-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-2273] Add onRedirecting login hook #1157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
added
enhancement
An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature
CH: Added
review:medium
Medium review
labels
Mar 11, 2021
frederikprijck
approved these changes
Mar 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CH: Added
enhancement
An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature
review:medium
Medium review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a hook function to
WebAuth.login
andWebAuth.passwordlessLogin
that would enable a developer to handle the event where a login ticket has been retrieved, just before redirecting away to the/authorize
endpoint.The hook is a function that can be specified, where the
done
function that is given must be called when the hook is complete, to let the SDK know that it can resume with authentication.Usage example:
Same for passwordless:
This PR also includes:
Testing
Checklist