[SDK-2391] Organizations support #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
added
CH: Added
enhancement
stevehobbsdev
commented
Mar 18, 2021
src/web-auth/index.js
Outdated
Comment on lines
345
to
365
| if (transactionOrganization) { | ||
| if (!payload.org_id) { | ||
| return callback( | ||
| error.invalidToken( | ||
| 'Organization Id (org_id) claim must be a string present in the ID token' | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
| if (payload.org_id !== transactionOrganization) { | ||
| return callback( | ||
| error.invalidToken( | ||
| 'Organization Id (org_id) claim value mismatch in the ID token; expected "' + | ||
| transactionOrganization + | ||
| '", found "' + | ||
| payload.org_id + | ||
| '"' | ||
| ) | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
This could have gone into validateToken, but putting it here has the advantage that we don't then need to make a breaking change to that method interface, which might be being used by a consumer of the SDK.
Happy of course to discuss alternatives.
added 6 commits
March 18, 2021 19:08
stevehobbsdev
force-pushed
the
sdk-2391/organizations
branch
from
e1bf014
to
7f67474
Compare
added 12 commits
March 18, 2021 19:14
adamjmcgrath
approved these changes
Mar 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds support for Organizations, currently in closed beta.
organizationandinvitationparameters (for user invitations)org_idclaimTesting
Checklist