Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace issue templates with issue forms [SDK-4168] #1302

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Apr 26, 2023

Changes

This PR replaces the Markdown-based issue templates with issue forms. These forms are a direct conversion of the Markdown issue templates, with the addition of a checklist at the top containing links to self-serve resources.

Checklist

@Widcket Widcket added the review:small Small review label Apr 26, 2023
@Widcket Widcket requested a review from a team as a code owner April 26, 2023 01:06
@@ -1,10 +1,10 @@
blank_issues_enabled: false
contact_links:
- name: Auth0 Community
url: https://community.auth0.com/c/sdks/auth0js/59
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path /c/sdks/auth0js/59 no longer exists.

Copy link
Contributor

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the question "Which browsers have you tested in", which is on the original bug report. Not sure if it would be too restrictive to have a drop-down list with the major ones in case they're using something obscure, will leave that up to you.

@Widcket
Copy link
Contributor Author

Widcket commented Apr 26, 2023

Please include the question "Which browsers have you tested in", which is on the original bug report. Not sure if it would be too restrictive to have a drop-down list with the major ones in case they're using something obscure, will leave that up to you.

Sure thing, added in 4b32d2c (I used the browsers in https://gs.statcounter.com/browser-market-share/desktop/worldwide). Copy-paste mishap, because this field is not present in another browser library I did previously: https://github.com/auth0/lock/blob/master/.github/ISSUE_TEMPLATE/report_a_bug.md#environment.

@stevehobbsdev
Copy link
Contributor

No worries, thanks. I think that change can/should be present in all the browser-based JS libraries (including Lock) but I can help roll it out as I see them 👍🏻

@stevehobbsdev stevehobbsdev enabled auto-merge (squash) April 26, 2023 11:52
@Widcket
Copy link
Contributor Author

Widcket commented Apr 26, 2023

Added it to the lock PR as well: auth0/lock#2324

@Widcket Widcket disabled auto-merge April 26, 2023 14:22
@Widcket Widcket merged commit 50de71b into master Apr 26, 2023
@Widcket Widcket deleted the chore/issue-forms branch April 26, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants