Bump to latest reqwest@2.0.5 #202
Conversation
|
Is the Winchan dependency issue also fixed in this? It makes a call to window.navigator that blows up in non browser environments. |
|
@paulwithap no, as you can see in the changes of the PR it only updates the reqwest depedency |
|
I'm on my phone and just woke up, so I figured I was missing something ;) Is there a reason that was left out? This only solves half of the problem. |
|
Because we wanted to fix the issue of the outdated dependency not the isomorphic one (we updated more outdated dependencies). Until we replace winchan it will always be a half fix, and we are planning to rethink the lib to better fit that use case. The current version was not design/implemented with considering server side rendering, this was meant to be a client library used inside a browser. |
|
Understandable. Do you have any recommendations for how to handle this in testing? I'm not even using server side rendering, but both of these issues suddenly started crashing mocha when I run tests. I'd love to keep using Auth0, but if it means I can't run tests, I obviously can't. |
|
That's odd, we run our test in mocha for auth0.js, we are using panthomjs and saucelabs (you can check the repo). You should probably split your fronted from your backend tests or mock Auth0.js |
|
The odd thing is that I was using your lib for weeks before it became an issue, and I can not for the life of me figure out what caused it to start. No amount of Git time travel will fix it. Also, I don't have a backend, so my code is about as isolated as it gets. I'll check out your config and see if I can get it working. This has been driving me nuts! |
|
@paulwithap did you get anywhere with this? Currently trying to use auth0-js with erikras' react-redux-universal-hot app but getting the |
|
Hi, we are soon to release auth0.js v8 and we are focusing all the effort in that. That version will not have a heavy dependency on the window object. Anyway, this SDK is intended for client side authentication. For your backend, this is the we to go https://github.com/auth0/node-auth0/ or https://auth0.com/docs/quickstart/webapp/nodejs |
Fixes #170