Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to specify custom popup size #379

Merged
merged 3 commits into from
Mar 9, 2017
Merged

Added possibility to specify custom popup size #379

merged 3 commits into from
Mar 9, 2017

Conversation

artemtool
Copy link
Contributor

When we want to use popup.authorize method it 's impossible to customize popup size.

this.auth0.popup.authorize({
            connection: 'facebook',
            redirectUri: 'any',
            popupOptions: {
                width: 200,
                height: 200
            }
        }

@codecov-io
Copy link

codecov-io commented Mar 7, 2017

Codecov Report

Merging #379 into master will decrease coverage by -0.09%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
- Coverage   97.62%   97.54%   -0.09%     
==========================================
  Files          35       35              
  Lines        1177     1179       +2     
  Branches      197      198       +1     
==========================================
+ Hits         1149     1150       +1     
- Misses         28       29       +1
Impacted Files Coverage Δ
src/web-auth/popup.js 92.85% <50%> (-0.9%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e5de1...f0e96d4. Read the comment docs.

@hzalaz hzalaz added this to the v8-Next milestone Mar 9, 2017
@hzalaz hzalaz merged commit 48dc331 into auth0:master Mar 9, 2017
@hzalaz hzalaz modified the milestones: v8-Next, v8.4.0 Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants