-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SilentSafariViewController dismisses before federated logout can complete #175
Comments
Hey @srgray curious what happens when testing in iOS11 and it uses SFAuthenticationSession pathway? |
@cocojoe When testing on iOS11 and using SFAuthenticationSession, the federated logout works properly. I suspect that this is because the SFAuthenticationSession view controller remains visible after the redirect to federated logout page. The user must manually tap 'Cancel' on SFAuthenticationSession to get it to dismiss. |
@cocojoe Any thoughts on this one? Is my assumption correct that the view is dismissing before it can redirect to the federated logout page? |
…oller. This allows a redirect to the federated logout page to happen before dismissal.
So I tested in iOS 10 using a Google connection (I don't have SAML setup) and saw that it got redirected to google before closing. Now it may well be a timing issue, once the first URL is hit the
|
OK, thanks for checking. For now, I'm going to add an arbitrary delay before the controller dismisses (on my fork of this repo, since it doesn't feel like a good, general solution). |
No problem, yes it's not ideal. That is why you may also want to try adding the
|
When performing a federated logout, SilentSafariViewController dismisses before the federated logout can complete. (tested on iOS 10)
I suspect that SilentSafariViewController successfully loads the Auth0 logout page and its delegate method is called to dismiss the controller before the redirect to the federated logout page can occur.
I verified this by placing an arbitrary delay of 1 second before the call to dismiss SilentSafariViewController. In that case, the federated logout did occur successfully. But this arbitrary delay doesn't seem like the correct solution to this issue.
The text was updated successfully, but these errors were encountered: