Skip to content
This repository has been archived by the owner on May 17, 2023. It is now read-only.

[Page Header] Create Page Header component #47

Closed
landitus opened this issue Dec 14, 2017 · 3 comments
Closed

[Page Header] Create Page Header component #47

landitus opened this issue Dec 14, 2017 · 3 comments

Comments

@landitus
Copy link
Contributor

landitus commented Dec 14, 2017

Give this component, we can call it 'Page header':

screen shot 2017-12-13 at 21 26 53

Has an option to show additional help:
screen shot 2017-12-13 at 21 26 59

Or can show a video tutorial
screen shot 2017-12-13 at 21 33 32

  • Should it be in the DS? Is it part of Manage's internal components? We've seen shopify has this kind of organisms (or bigger components).
  • If we added to the system, should it be as 'open' or 'closed' component?
  • Does this logic apply to all organisms?
@landitus
Copy link
Contributor Author

Kind of relates to issue: #40

Rigid components will help make it easier to test and maintain components. This can feel limiting at first, but it will help us build consistent UIs and remove some of the decision fatigue while picking components. (Bonus: easier to test + maintain)

I'm sure we can debate about flexibility and rigidity here as well 😁

@landitus landitus changed the title Group of components (or organisms) should be closed or open Page Header component (or organism) should be closed or open Dec 14, 2017
@landitus landitus changed the title Page Header component (or organism) should be closed or open Page Header component (or organism) should be closed or open? Dec 14, 2017
@landitus landitus mentioned this issue Dec 18, 2017
33 tasks
@landitus
Copy link
Contributor Author

I think that for the PoC we could change the tutorial video and add it as a modal. This way, the Page header component will be more simple

@siddharthkp
Copy link
Contributor

I don't think the helper text should be part of the PageHeader component as well, we want to control the layout not the content

In my head, the API should be:

<PageHeader title="Clients" actions={[...]} descriptionComponent={whateverYouNeed}/>

@landitus landitus added the PoC label Jan 4, 2018
@nkohari nkohari changed the title Page Header component (or organism) should be closed or open? Page Header Component Jan 4, 2018
@nkohari nkohari added this to To do in Milestone 1: PoC Clients Section via automation Jan 4, 2018
@siddharthkp siddharthkp added the 🖥️api / dx Improvements to developer/user experience label Jan 5, 2018
@siddharthkp siddharthkp moved this from To do to Inbox in Milestone 1: PoC Clients Section Jan 8, 2018
@landitus landitus moved this from Inbox to To do in Milestone 1: PoC Clients Section Jan 11, 2018
@beneliflo beneliflo self-assigned this Jan 16, 2018
@beneliflo beneliflo moved this from To do to In progress in Milestone 1: PoC Clients Section Jan 24, 2018
@nkohari nkohari removed the PoC label Feb 8, 2018
@nkohari nkohari added this to Backlog in Alpha Release via automation Feb 8, 2018
@nkohari nkohari removed 🖥️api / dx Improvements to developer/user experience discussion labels Feb 8, 2018
@nkohari nkohari changed the title Page Header Component [Page Header] Create new component Feb 8, 2018
@nkohari nkohari moved this from Backlog to Needs Review in Alpha Release Feb 8, 2018
@nkohari nkohari changed the title [Page Header] Create new component [Page Header] Create Page Header Component Feb 8, 2018
@nkohari nkohari changed the title [Page Header] Create Page Header Component [Page Header] Create Page Header component Feb 8, 2018
@siddharthkp siddharthkp moved this from Needs Review to In Progress in Alpha Release Feb 9, 2018
@landitus landitus moved this from In Progress to Needs Review in Alpha Release Feb 14, 2018
@landitus landitus moved this from Needs Review to In Progress in Alpha Release Feb 14, 2018
@nkohari nkohari moved this from In Progress to Done in Alpha Release Feb 16, 2018
@nkohari nkohari closed this as completed Mar 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

4 participants