Add allowed signing algorithms in validator #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
reviewed
Dec 7, 2021
| PS384 = SignatureAlgorithm("PS384") // RSASSA-PSS using SHA384 and MGF1-SHA384 | ||
| PS512 = SignatureAlgorithm("PS512") // RSASSA-PSS using SHA512 and MGF1-SHA512 | ||
| ) | ||
|
|
||
| // Validator to use with the jose v2 package. | ||
| type Validator struct { |
There was a problem hiding this comment.
Does this type need to be exported? It has a field of type jwt.Expected, which is from the underlying library.
There was a problem hiding this comment.
Unfortunately we can't make it private because of the following linting error:
validator/validator.go:65:4: unexported-return: exported func New returns unexported type *validator.validator, which can be annoying to use (revive)
) (*validator, error) {
The field type of jwt.Expected is not exported so there should not be any issues IMO:)
Widcket
reviewed
Dec 7, 2021
sergiught
force-pushed
the
patch/signing-method
branch
from
a77e338
to
5d3c76a
Compare
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
=======================================
Coverage 89.32% 89.32%
=======================================
Files 7 7
Lines 178 178
=======================================
Hits 159 159
Misses 12 12
Partials 7 7
Continue to review full report at Codecov.
|
|
Had to push again as the github actions were stuck. |
frederikprijck
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we add allowed signing algorithms for the validator.
References
Testing
Checklist
master.