Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve concurrency #134

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Improve concurrency #134

merged 1 commit into from
Jan 6, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Jan 6, 2022 •
edited

Description

In this PR we are starting to run by default tests with the -race flag to check for concurrency issues and making the implementation guard against potential issues.

馃弳 A special thanks goes to @jessieA for helping us improve this together 馃挭馃徎 ! We really appreciate the time dedicated in collaborating with us for the good of the community!

References

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have read and agreed to the terms within the Auth0 Code of Conduct.
  • I have read the Auth0 General Contribution Guidelines.
  • I have reviewed my own code beforehand.
  • I have added documentation for new/changed functionality in this PR.
  • All active GitHub checks for tests, formatting, and security are passing.
  • The correct base branch is being used, if not master.

@codecov-commenter

This comment has been minimized.

Sign in to view
@sergiught sergiught self-assigned this Jan 6, 2022
@sergiught sergiught marked this pull request as ready for review January 6, 2022 15:35
@sergiught sergiught requested a review from a team as a code owner January 6, 2022 15:35
@sergiught sergiught merged commit c690994 into master Jan 6, 2022
@sergiught sergiught deleted the patch/improve-concurrency branch January 6, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees

@sergiught sergiught

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sergiught @codecov-commenter @Widcket