Remove ES256K support #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We have internally decided to remove ES256K algorithm since it has been disabled in Java 15+
We have removed ES256K construction methods from Algorithm method
We have removed related tests, support files for tests and related constants
We have not updated the README notice since it would be better for it to be there for sometime
References
https://www.oracle.com/java/technologies/javase/15-relnote-issues.html#JDK-8237219
Testing
Removed ES256K alg to identify all the compiler errors in test.
Removed related files and constants were tested manually.