Avoid using any bundlers but use tsc instead #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikprijck
changed the title
|
Needs to be rebased after #193 is merged as I wanted to drop UMD separately to keep this PR more focussed. |
|
I'll put in a review for this once we merge #193 😄 |
frederikprijck
force-pushed
the
chore/drop-bundlers
branch
from
5e56ac0
to
11b1882
Compare
|
Rebased on top of latest beta. |
|
Got some review comments, but I think it would be better as a PR, so I will open one up on top of this one. |
|
I've created #194 with some work that came out of the review. Everything else is looking good to me 👍 |
|
Thanks @jonkoops ! |
frederikprijck
changed the title
ewanharris
approved these changes
Aug 16, 2023
Merged
frederikprijck
added a commit
that referenced
this pull request
Oct 27, 2023
Co-authored-by: Jon Koops <jonkoops@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Given the size of the library, we might want to consider dropping any bundler altogether but move everything into a single file.
According to Are The Types Wrong, this is still outputting correct types:
Marked as draft to further investigate.
Checklist