Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Commit

Permalink
comment
Browse files Browse the repository at this point in the history
Signed-Off-By Travis Schoenberg <traviisd@gmail.com>
  • Loading branch information
traviisd committed Aug 6, 2020
1 parent 1137ab3 commit d97ffb7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion os/os_interactor.go
Expand Up @@ -25,7 +25,7 @@ func (i *DefaultInteractor) OpenURL(url string) error {
// The character & is treated as running a separate command in Windows
// cmd /c start "http://domain.com?param1&param2" results in trying to run cmd /c "start http://domain.com?parm1" & param2
// Also, the " char is used as the delimiter to escape special characters, so "&" would become \&\
// cmd /c start 'http://domain.com?param1"&"param2' works when inputting directly to the command prompt,
// cmd /c start 'http://domain.com?param1=value with space"&"param2=value2' works when inputting directly to the command prompt,
// but the "&" is escaped by \"&\" when passed from code, which becomes \&\, resulting in cmd /c start 'http://domain.com?param1\&\param2'
// And spaces will not work within the string we need to encode only the whitespace.
// SO, this code creates the correct URL string, adds the start command to a powershell file and executes powershell
Expand Down

0 comments on commit d97ffb7

Please sign in to comment.