Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow store and state_handler to be passed in from config #156

Merged
merged 3 commits into from
Nov 14, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Nov 13, 2019

Changes

  • Fix a bug that did not allow the configuration file values to be used for user store and state handler
  • Fix a type hinting bug that did not allow new state handlers to be passed in
  • Add a compatibility scan to CI

References

Closes #154

Testing

  • This change adds unit tests
  • This change has been tested on PHP 7.1 and Laravel 5.8

nstapelbroek
nstapelbroek previously approved these changes Nov 13, 2019
Copy link
Contributor

@nstapelbroek nstapelbroek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care 💪

Tested this functionally on my local setup with no configs set to false and that works.

@joshcanhelp
Copy link
Contributor Author

joshcanhelp commented Nov 13, 2019

Added a failed PHP compatibility test for PHP 5.5

9072d6c

> "vendor/bin/phpcs"
.E.......... 12 / 12 (100%)

FILE: src/Auth0/Login/Auth0Service.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 48 | ERROR | null coalescing operator (??) is not present in PHP
    |       | version 5.6 or earlier
    |       | (PHPCompatibility.PHP.NewLanguageConstructs.t_coalesceFound)
 53 | ERROR | null coalescing operator (??) is not present in PHP
    |       | version 5.6 or earlier
    |       | (PHPCompatibility.PHP.NewLanguageConstructs.t_coalesceFound)
----------------------------------------------------------------------

@joshcanhelp joshcanhelp added this to the 5.3.1 milestone Nov 14, 2019
@joshcanhelp joshcanhelp marked this pull request as ready for review November 14, 2019 14:10
@joshcanhelp joshcanhelp requested a review from a team November 14, 2019 14:10
@joshcanhelp joshcanhelp merged commit 1b84e44 into master Nov 14, 2019
@joshcanhelp joshcanhelp deleted the fix-store-and-state-handing branch November 14, 2019 20:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting of state_handler in Auth0Service causes "Invalid state" error
3 participants