Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2325] fix: Avoid throwing an error when calling getUserByUserInfo() during login callback event when the supplied profile is empty/null #207

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

evansims
Copy link
Member

@evansims evansims commented Feb 16, 2021

In some cases, our Laravel plugin will return null when getUser() is called. We do not currently handle these instances correctly and instead throw an error when we take this null response and attempt to pass it to User::getUserByUserInfo(), which only accepts array values. Reported here.

…login callback event when the supplied profile is empty/null
@evansims evansims requested a review from a team as a code owner February 16, 2021 23:12
@evansims evansims changed the title fix: Avoid throwing an error when calling getUserByUserInfo() during login callback event when the supplied profile is empty/null [SDK-2325] fix: Avoid throwing an error when calling getUserByUserInfo() during login callback event when the supplied profile is empty/null Feb 16, 2021
@evansims evansims added this to the 6.3.0 milestone Feb 16, 2021
@evansims evansims merged commit 3974b28 into master Feb 17, 2021
@evansims evansims deleted the fix-sdk-2325 branch February 17, 2021 13:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants