Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-2784] Add alias methods for SDK's Passwordless API methods #228

Merged
merged 1 commit into from
Oct 4, 2021
Merged

[SDK-2784] Add alias methods for SDK's Passwordless API methods #228

merged 1 commit into from
Oct 4, 2021

Conversation

evansims
Copy link
Member

@evansims evansims commented Oct 3, 2021 •
edited

Changes

This PR:

  • Adds support for the two auth0-php 7.x passwordless API methods, email_passwordless_start and sms_passwordless_start.
  • Adds a getAuthenticationClass() class for creating a singleton instance of the Auth0\SDK\API\Authentication class.
  • Does not introduce new testing due to the simplicity of these alias methods and the presence of existing tests on the parent SDK for these methods. (This plugin will be receiving an overall Q4 which will introduce better testing conditions.)

References

Testing

You can run tests locally using a Docker container by issuing composer run tests from your shell.

Contributor Checklist

@evansims evansims marked this pull request as ready for review October 3, 2021 19:08
@evansims evansims requested a review from a team as a code owner October 3, 2021 19:08
@evansims evansims merged commit 87ef20a into main Oct 4, 2021
@evansims evansims deleted the passwordless branch October 4, 2021 12:01
@evansims evansims mentioned this pull request Oct 15, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose passwordless support from underlying SDK.
2 participants
@evansims @lbalmaceda