Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-4337] feat: Add setting to define search path for configuration files #407

Merged
merged 4 commits into from
Jun 13, 2023

Conversation

evansims
Copy link
Member

Changes

This PR adds an optional configurationPath setting to the config/auth0.php SDK configuration file for applications, which allows developers to specify the search path the SDK will use to search for configuration files (.auth0..json, .env).

References

Closes #397

Testing

Test coverage remains at 100%.

Contributor Checklist

@evansims evansims added the Scope: Improvement Proposed improvements, or feature additions. label Jun 13, 2023
@evansims evansims marked this pull request as ready for review June 13, 2023 19:14
@evansims evansims requested a review from a team as a code owner June 13, 2023 19:14
@evansims evansims enabled auto-merge June 13, 2023 19:21
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (41ca3d6) 100.00% compared to head (5ccb001) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #407   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       496       497    +1     
===========================================
  Files             31        31           
  Lines           1271      1274    +3     
===========================================
+ Hits            1271      1274    +3     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Configuration.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@evansims evansims changed the title feat: Add setting to define search path for configuration files [SDK-4337] feat: Add setting to define search path for configuration files Jun 13, 2023
@evansims evansims added this pull request to the merge queue Jun 13, 2023
Merged via the queue into main with commit 10e038b Jun 13, 2023
10 checks passed
@evansims evansims deleted the feat/configuration-path-setting branch June 13, 2023 22:20
@evansims evansims mentioned this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Improvement Proposed improvements, or feature additions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.env and json file location option
2 participants