Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-4337] fix: Restore host environment variable processing #408

Merged
merged 5 commits into from
Jun 13, 2023

Conversation

evansims
Copy link
Member

@evansims evansims commented Jun 13, 2023

Changes

This PR restore previous host environment variable configurations, in addition to the "dotenv" and JSON-based configuration methods.

References

Closes #405

Testing

Test coverage remains at 100%.

Contributor Checklist

@evansims evansims added the Scope: Bug Confirmed report of unexpected problems or unintended behavior. label Jun 13, 2023
@evansims evansims marked this pull request as ready for review June 13, 2023 19:21
@evansims evansims requested a review from a team as a code owner June 13, 2023 19:21
@evansims evansims enabled auto-merge June 13, 2023 19:21
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (41ca3d6) 100.00% compared to head (5a914a1) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #408   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       496       500    +4     
===========================================
  Files             31        31           
  Lines           1271      1274    +3     
===========================================
+ Hits            1271      1274    +3     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Configuration.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@evansims evansims changed the title fix: Restore host environment variable processing [SDK-4337] fix: Restore host environment variable processing Jun 13, 2023
@evansims evansims added this pull request to the merge queue Jun 13, 2023
Merged via the queue into main with commit 6275efe Jun 13, 2023
10 checks passed
@evansims evansims deleted the fix/restore-env-var-parsing branch June 13, 2023 22:15
@evansims evansims mentioned this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Bug Confirmed report of unexpected problems or unintended behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 7.8 environment configuration no longer calls system configuration just file
2 participants