[SDK-4338] feat: GuardAbstract extends Illuminate\Contracts\Auth\Guard
#410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evansims
added
the
Scope: Improvement
evansims
changed the title
GuardAbstract extends Illuminate\Contracts\Auth\GuardGuardAbstract extends Illuminate\Contracts\Auth\Guard
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
===========================================
Coverage 100.00% 100.00%
+ Complexity 501 496 -5
===========================================
Files 31 31
Lines 1276 1271 -5
===========================================
- Hits 1276 1271 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Widcket
approved these changes
Jun 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR updates
Auth0\Laravel\Guards\GuardAbstractabstract class (which is extended by the concreteAuth0\Laravel\Guards\AuthenticationGuardandAuth0\Laravel\Guards\AuthorizationGuardclasses) to extend theIlluminate\Contracts\Auth\Guardinterface. This is a framework interface provided by Laravel.No functional changes related to this change, but extending it is suggested as a best practice.
References
Addresses feedback from @devfrey in #385.
Testing
Test coverage remains at 100%.
Contributor Checklist