Code style & docblocks #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix code style to PSR-2 & add missing docblocks
Correct minor typos in readme
Added flag for not encoded tokens + removed example
glena
suggested changes
Nov 29, 2016
|
|
||
| * Regular webapp: https://auth0.com/docs/quickstart/webapp/laravel/ | ||
| * Web API: https://auth0.com/docs/quickstart/backend/php-laravel/ | ||
|
|
||
| > If you find something wrong in our docs, PR are welcome in our docs repo: https://github.com/auth0/docs | ||
|
|
||
| ### Setting up a JWKs cache |
There was a problem hiding this comment.
This is meant to be JWK (json web keys) and not JWT. JWK is the endpoint that returns the public key to verify the token
Fix code style to PSR-2 & add missing docblocks
Correct minor typos in readme
# Conflicts: # src/Auth0/Login/Auth0Service.php # src/Auth0/Login/LoginServiceProvider.php
|
@glena Please check if this PR is good to go :) |
glena
approved these changes
Dec 1, 2016
|
💥 awesome! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix code style to PSR-2 & add missing docblocks