Utilise Auth0->Login to ensure state validation #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no auth0-PHP 5.1 yet, release that first and can then test this for a quick release. |
Update auth0-PHP dependency
cocojoe
force-pushed
the
update-use-auth0-login
branch
from
713dbc5
to
d015be6
Compare
|
Don't merge. |
…elling in function signature
lbalmaceda
reviewed
Mar 5, 2018
| @@ -51,10 +51,10 @@ public function logout() | |||
| /** | |||
| * Redirects the user to the hosted login page | |||
| */ | |||
| public function login($connection = null, $state = null, $aditional_params = ['scope' => 'openid profile email'], $response_type = 'code') | |||
| public function login($connection = null, $state = null, $additional_params = ['scope' => 'openid profile email'], $response_type = 'code') | |||
There was a problem hiding this comment.
This looks at first like a BREAKING CHANGE. Is it just the parameter name, used internally in this method logic or can people actually call this method passing a dictionary with the ${param_name} as keys?
There was a problem hiding this comment.
@lbalmaceda - No fancy stuff here, just the internal signature.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update auth0-PHP dependency