This repository has been archived by the owner on May 1, 2019. It is now read-only.
Playground fixes #75
Merged
Playground fixes #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gnandretta
commented
Oct 27, 2015
gnandretta
commented
- After clicking the "Open Me!" button, the lock was being closed when any key was pressed.
- Clean event handler for close button click. The close button is never displayed when the Lock is rendered in a container, so there's no need to check that.
- Add comments for event handlers that render the Lock in the container after it has been closed.
A new Lock needs to be rendered in the #container after it has been closed with ESC. We ensure ESC has actually been pressed (keyCode 23) and that there is a close button in the DOM (otherwise the Lock can't be closed with ESC).
There's no need to check if the Lock is rendered in a container, because it can't be closed in such situation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.