Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravatar animation fixes #45

Closed
6 tasks done
pose opened this issue Sep 17, 2014 · 0 comments
Closed
6 tasks done

Gravatar animation fixes #45

pose opened this issue Sep 17, 2014 · 0 comments

Comments

@pose
Copy link
Contributor

pose commented Sep 17, 2014

  • move 500 to a constant and align it to the .animation.fast's animation-duration.
  • Add a _.debounce to onemailinput handler.
    • signin
    • signup
  • Make the change of logo only when succeeding loading the image (probably, preload it somewhere else) when {icon: 'http://....'} This has been solved by the _.dobounce
  • ~~ When erasing the whole email in some cases the picture converts to a square.~~ Cannot reproduce, but fixed some related bug.
@pose pose closed this as completed in 337a0b4 Sep 19, 2014
gnandretta pushed a commit that referenced this issue Mar 23, 2016
billbonney pushed a commit to billbonney/lock that referenced this issue Jun 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant