Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10] Propagate signup errors from rules to lock widget #580

Closed
colllin opened this issue Aug 24, 2016 · 7 comments
Closed

[v10] Propagate signup errors from rules to lock widget #580

colllin opened this issue Aug 24, 2016 · 7 comments
Assignees

Comments

@colllin
Copy link

colllin commented Aug 24, 2016

Lock Version: v10.0
See https://auth0.com/forum/t/propagate-signup-errors-from-rules-to-lock-widget-v10/3108

@colllin colllin changed the title Propagate signup errors from rules to lock widget [v10] Propagate signup errors from rules to lock widget Aug 24, 2016
@hzalaz
Copy link
Member

hzalaz commented Aug 24, 2016

Can you provide any more details like what error you see? how the rule returns the error or is it the a custom db script?

@colllin
Copy link
Author

colllin commented Aug 25, 2016

It's a rule returning an error using the callback. It worked great on v9. The error message displayed in the lock dialog. What other details would be helpful?

On Aug 24, 2016, 11:37 AM -0600, Hernan Zalazar notifications@github.com, wrote:

Can you provide any more details like what error you see? how the rule returns the error or is it the a custom db script?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (#580 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AALWQ6s2P6xY2wxAdzXRJD8wmpauyNRcks5qjIFUgaJpZM4JsK5H).

@woloski woloski added the bug This points to a verified bug in the code label Aug 30, 2016
@hzalaz hzalaz added the v10 label Sep 2, 2016
@rashfael
Copy link

Having the same problem.

I throw a UnauthorizedError in a rule.
In popup mode the error message gets rendered, but not in redirect mode.

Both the hash_parsed and authorization_error events get triggered with the error message, but the error never gets displayed.

@hzalaz hzalaz removed bug This points to a verified bug in the code P3: Important labels Oct 3, 2016
@hzalaz
Copy link
Member

hzalaz commented Oct 3, 2016

Closing this one.

It works for rules if the error is UnauthorizedError and lock will display that one. If the error returned from the rule is another one, e.g. Error it won't be displayed by Lock.

Errors raised in the custom db scripts, in this case signup, are not handled yet by Lock but it's in our backlog.

@hzalaz hzalaz closed this as completed Oct 3, 2016
@rashfael
Copy link

rashfael commented Oct 3, 2016

I throw an UnauthorizedError, and it gets displayed, but only in popup mode, not in redirect mode.
Even the events get emitted, but the error is not displayed.

@colllin
Copy link
Author

colllin commented Nov 2, 2016

@hzalaz Did you see this latest comment? Sounds like it should be reopened.

@hzalaz
Copy link
Member

hzalaz commented Nov 2, 2016

Yes, but is more related to #639 since for redirect lock is not displayed when you are redirected back to your site, Lock does not store any auth result by itself, so you have to either show an error page of your choosing or open Lock with a flash message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants