Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When in OIDC mode enterprise connections always go to IdP page #1019

Merged
merged 1 commit into from
Jun 14, 2017

Conversation

luisrudge
Copy link
Contributor

No description provided.

@luisrudge luisrudge added this to the v10-Next milestone May 30, 2017
@luisrudge luisrudge force-pushed the feature-adfs-error-cross-origin branch from a60c2f9 to c74f520 Compare May 31, 2017 20:10
@hzalaz hzalaz self-requested a review June 8, 2017 02:57
Copy link
Member

@hzalaz hzalaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good but we could also force all enterprise flows to /authorize when OIDC is on to avoid errors. (We can leave the error just in case)

@luisrudge luisrudge force-pushed the feature-adfs-error-cross-origin branch from c74f520 to 666dec3 Compare June 13, 2017 21:07
@luisrudge luisrudge force-pushed the feature-adfs-error-cross-origin branch from 666dec3 to 8bcd269 Compare June 14, 2017 18:32
@hzalaz hzalaz changed the title Throw an error when using OIDC and AD When in OIDC mode enterprise connections always go to IdP page Jun 14, 2017
@hzalaz hzalaz merged commit e133d78 into master Jun 14, 2017
@hzalaz hzalaz deleted the feature-adfs-error-cross-origin branch June 14, 2017 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants