Added a custom connection resolver option #1052
Conversation
luisrudge
force-pushed
the
feature-connection-resolver
branch
3 times, most recently
from
a4d4dfb
to
35762d9
Compare
luisrudge
force-pushed
the
feature-connection-resolver
branch
from
35762d9
to
f06d3a0
Compare
README.md
Outdated
| @@ -292,6 +292,23 @@ var options = { | |||
| - **configurationBaseUrl {String}**: Overrides client settings base url. By default it uses Auth0's CDN url when `domain` has the format `*.auth0.com`. Otherwise, it uses the provided `domain`. | |||
| - **languageBaseUrl {String}**: Overrides the language source url for Auth0's provided translations. By default it uses to Auth0's CDN url `https://cdn.auth0.com`. | |||
| - **hashCleanup {Boolean}**: When enabled, it will remove the hash part of the callback url after the user authentication. Defaults to `true`. | |||
| - **connectionResolver {Function}**: When in use, provides an extensibility point to make it possible to chose which connection to use based on the username information. Has `username`, `context` and `callback` as parameters. The callback expects an object like: `{type: 'database', name: 'connection name'}`. **This only works for database connections.** | |||
There was a problem hiding this comment.
The name connectionResolver is ok as long we don't have a provider or similar concept elsewhere. If we do lets be consistent 😄
There was a problem hiding this comment.
only gravatar provider, but it's not part of the public api.
README.md
Outdated
| cb({ type: 'database', name: domain }); | ||
| } else { | ||
| // Use the default approach to figure it out the connection | ||
| cb(undefined); |
There was a problem hiding this comment.
I'd rather use cb(null) or even cb() and we should handle both cases gracefully
There was a problem hiding this comment.
Also in the implementation lets add a warning or timeout if this operation takes too long (could be in a diff PR as long as we add a note saying Keep It Simple)
There was a problem hiding this comment.
it doesn't really matter what you set here.. null, empty, undefined, false.. everything that evaluates to false will make it behave the same.
I'll add a note in the readme because the timeout will come back to bite us for sure
There was a problem hiding this comment.
Ok but let's remove the cb(undefined) from he example, and that we have a good error when the object you pass is empty or has a wrong format
luisrudge
force-pushed
the
feature-connection-resolver
branch
2 times, most recently
from
7da2733
to
cde8a9a
Compare
luisrudge
force-pushed
the
feature-connection-resolver
branch
from
cde8a9a
to
9c4c21f
Compare
luisrudge
changed the title
fix #937