Update auth0.js and add flag to enable impersonation #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
reviewed
Mar 9, 2018
package.json
Outdated
| @@ -87,7 +87,7 @@ | |||
| "zuul-ngrok": "4.0.0" | |||
| }, | |||
| "dependencies": { | |||
| "auth0-js": "^9.3.0", | |||
| "auth0-js": "^9.3.3", | |||
| "blueimp-md5": "2.3.1", | |||
| "fbjs": "^0.3.1", | |||
| "idtoken-verifier": "^1.0.1", | |||
There was a problem hiding this comment.
Shouldn't this be bumped too?
There was a problem hiding this comment.
I removed the direct dependency
lbalmaceda
reviewed
Mar 9, 2018
| expect(parseHashMock.calls.length).toBe(1); | ||
| expect(parseHashMock.calls[0]).toMatchSnapshot(); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Besides checking that the option is set on the auth0js client, you can also check that a real auth0js client can parse or throws an exception depending on the flag and on the state passed in the hash. (2 more tests)
There was a problem hiding this comment.
I'm not testing auth0.js internals inside lock
joshcanhelp
approved these changes
Mar 12, 2018
9 tasks
This was referenced May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.