Trim auth params before sending to the API (not while typing) #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luisrudge can you clarify your description please, you trim on submission of the field or it's only trimmed when an API request is made? |
|
@cocojoe I only trim the value being sent to the API. The input value is left untouched. |
lbalmaceda
reviewed
Nov 13, 2018
src/core/web_api/helper.js
Outdated
|
|
||
| export function trimAuthParams(params = {}) { | ||
| const { ...p } = params; | ||
| ['username', 'email', 'phoneNumber'].forEach(k => { |
joshcanhelp
reviewed
Nov 13, 2018
| ...this.authOpt, | ||
| ...authParams | ||
| }); | ||
| const loginOptions = trimAuthParams( |
There was a problem hiding this comment.
The function wrap feels ... wrong. Can trimAuthParams be a part of normalizeAuthParams? What if we need to do another transform here? Maybe there should be a prepareParams or similar to handle everything?
joshcanhelp
reviewed
Nov 13, 2018
| } | ||
|
|
||
| resetPassword(options, cb) { | ||
| this.client.changePassword(options, cb); | ||
| this.client.changePassword(trimAuthParams(options), cb); |
There was a problem hiding this comment.
Similar feedback here ... there might be another transform in the future, in which case this starts to get really hard to read.
joshcanhelp
previously approved these changes
Nov 13, 2018
lbalmaceda
approved these changes
Nov 13, 2018
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1537
Changes
Instead of trimming email/username/phoneNumber while the user is typing, we're now trimming them when we send them to the server.
References
#1537
Testing