Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lock center position with scroll across browsers #1594

Merged
merged 2 commits into from
Jan 28, 2019
Merged

Fix lock center position with scroll across browsers #1594

merged 2 commits into from
Jan 28, 2019

Conversation

luisrudge
Copy link
Contributor

fix #1591
also revers and fixes #1566

Changes

  • Set position to fixed to make sure it's always centered in the screen
  • Set overflow-x to auto to make sure lock always scrolls when the signup form is bigger than the viewport

References

#1591
#1566

Fix for #1591

fix1

Fix for #1566

fix2

@luisrudge luisrudge added this to the v11.13.2 milestone Jan 24, 2019
@luisrudge luisrudge merged commit 228daa5 into master Jan 28, 2019
@luisrudge luisrudge deleted the fix/lock-centered-with-scroll branch January 28, 2019 13:58
@luisrudge luisrudge mentioned this pull request Feb 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v11.13.2
Development

Successfully merging this pull request may close these issues.

Broken vertical alignment in 11.13.0
2 participants
@luisrudge @lbalmaceda