Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix layout when using big string for terms #1631

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Fix layout when using big string for terms #1631

merged 1 commit into from
Apr 10, 2019

Conversation

luisrudge
Copy link
Contributor

Changes

Fix an UI issue when using a big string in the 'accept terms' area.

References

Before

image

image

image

After

image
image
image
image

@luisrudge luisrudge added this to the v11.14.2 milestone Apr 10, 2019
doomislegend
doomislegend approved these changes Apr 10, 2019
View reviewed changes
Copy link

@doomislegend doomislegend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luisrudge luisrudge merged commit de830cb into master Apr 10, 2019
@luisrudge luisrudge deleted the fix/big-terms-layout branch April 10, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

@doomislegend doomislegend doomislegend approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v11.15.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luisrudge @lbalmaceda @doomislegend