Remove socialButtonStyle option to use small icons #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisrudge
changed the title
|
Related to #1510 Source: https://developers.google.com/identity/branding-guidelines#incorrect
|
davidpatrick
previously approved these changes
Apr 23, 2019
lbalmaceda
approved these changes
Apr 30, 2019
There was a problem hiding this comment.
Please remember to add this as part of the changelog (on the release PR)
Changed: The option to display social connections in small styled buttons is no longer available due to branding compliance reasons with third party identity providers. All the social connections will now be displayed as large styled buttons.
5 tasks
|
omg this is ugly with multiple providers. there has got to be a better experience than a massive towering list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removes the
socialButtonStyleoption. This will remove the option to usesmallicons.