Add validation to new root profile attributes #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisrudge
force-pushed
the
feature/new-fields-validation
branch
from
a48ccbd
to
d5319a6
Compare
damieng
suggested changes
Jun 26, 2019
damieng
previously approved these changes
Jul 9, 2019
panga
reviewed
Jul 9, 2019
src/field/username.js
Outdated
| @@ -3,8 +3,8 @@ import { validateEmail } from './email'; | |||
| import { databaseConnection } from '../connection/database'; | |||
| import trim from 'trim'; | |||
|
|
|||
| const DEFAULT_CONNECTION_VALIDATION = { username: { min: 1, max: 15 } }; | |||
| const regExp = /^[a-zA-Z0-9_+\-.]+$/; | |||
| const DEFAULT_CONNECTION_VALIDATION = { username: { min: 1, max: 128 } }; | |||
There was a problem hiding this comment.
The default didn't change, still 15 chars.
| @@ -55,5 +55,5 @@ export function setUsername(m, str, usernameStyle = 'username', validateUsername | |||
| } | |||
|
|
|||
| export function usernameLooksLikeEmail(str) { | |||
| return str.indexOf('@') > -1; | |||
| return str.indexOf('@') > -1 && str.indexOf('.') > -1; | |||
There was a problem hiding this comment.
Can you please use a more robust email validation library?
Ideally, the same library used in the backend should be used in Lock:
https://github.com/validatorjs/validator.js#client-side-usage
There was a problem hiding this comment.
this validation is only for cases that the browser doesn't support html5 validation, since we use that by default. we're not adding +20kb just to do email validation 😬
| invalidChars.forEach(i => expectToFailWith(`aa${i}`)); | ||
| }); | ||
| it('accepts letters, numbers, `_`, `-`, `+` and `.`', () => { | ||
| const validChars = `_-+.`.split(''); | ||
| const validChars = `_+-.!#$'^\`~@`.split(''); |
There was a problem hiding this comment.
Suggestion: Update test title with new chars
damieng
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add default validation for new root profile attributes
Testing