Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map password_expired to password_change_required #1730

Merged
merged 3 commits into from
Oct 10, 2019

Conversation

luisrudge
Copy link
Contributor

Changes

This PRs fixes an error mapping (from password_expired to password_change_required) in order to provide a better error message for end users.

References

Fix #1719

Testing

  • This change adds unit test coverage

@luisrudge luisrudge requested a review from a team September 24, 2019 18:26
@luisrudge luisrudge added this to the v11.17.3 milestone Sep 24, 2019
@joshcanhelp joshcanhelp removed the request for review from a team October 7, 2019 21:40
@joshcanhelp
Copy link
Contributor

@luisrudge - Looks like this is a WIP so I removed our team for now. Add us back when you're ready!

@luisrudge luisrudge requested a review from a team October 9, 2019 02:10
damieng
damieng previously approved these changes Oct 9, 2019
@luisrudge luisrudge modified the milestones: v11.17.3, v11.18.0 Oct 10, 2019
@luisrudge luisrudge merged commit 27c7c2b into master Oct 10, 2019
@damieng damieng deleted the fix/password-expired-mapping branch November 26, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

password_expired error during login is not being mapped to password_change_required
3 participants