[SDK-1361] Adjust styling for social buttons and Apple compliance #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 12, 2020 12:23
- Moved icon element inside text element so they can be center-aligned - Applied flex styling to text element and center justified - Text font, letter spacing and casing changes to match new style
5 tasks
joshcanhelp
previously approved these changes
Feb 14, 2020
|
@joshcanhelp That may be about to change.. |
|
@joshcanhelp This has now been changed so that the buttons have their text left-aligned once again. Screenshots in the original post have been updated. |
Widcket
reviewed
Feb 17, 2020
Widcket
approved these changes
Feb 17, 2020
jfromaniello
pushed a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Mar 5, 2020
…th0#1801) * Reworked social button styling - Moved icon element inside text element so they can be center-aligned - Applied flex styling to text element and center justified - Text font, letter spacing and casing changes to match new style * Modified button text on login and signup to "Sign in with.." * Fixed button hover styling, added retina media query * Adjusted styling for Google login button * Modified border color for Google login button * Updated snapshots * Reverted 'sign up with..' text * Re-aligned text to the left * Updated snapshots * CSS formatting
davidpatrick
pushed a commit
to davidpatrick/lock
that referenced
this pull request
Jun 12, 2020
…th0#1801) * Reworked social button styling - Moved icon element inside text element so they can be center-aligned - Applied flex styling to text element and center justified - Text font, letter spacing and casing changes to match new style * Modified button text on login and signup to "Sign in with.." * Fixed button hover styling, added retina media query * Adjusted styling for Google login button * Modified border color for Google login button * Updated snapshots * Reverted 'sign up with..' text * Re-aligned text to the left * Updated snapshots * CSS formatting
jfromaniello
pushed a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Jul 23, 2020
…th0#1801) * Reworked social button styling - Moved icon element inside text element so they can be center-aligned - Applied flex styling to text element and center justified - Text font, letter spacing and casing changes to match new style * Modified button text on login and signup to "Sign in with.." * Fixed button hover styling, added retina media query * Adjusted styling for Google login button * Modified border color for Google login button * Updated snapshots * Reverted 'sign up with..' text * Re-aligned text to the left * Updated snapshots * CSS formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR primarily adjusts the "Sign in with Apple" button to better match Apple's guidelines.
A knock-on effect is that the other social login buttons have had their designs updates to match, for consistency.
Additionally, "Sign up with.." text has been changed into "Sign in with.." across the signup and login tabs.
Before
After
References
This was raised through an internal customer support ticket.
Testing
This PR contains no functional changes, only visual.
Checklist