[SDK-1556] Apply window height style to root document for Passwordless UI #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
changed the title
stevehobbsdev
changed the title
lbalmaceda
approved these changes
Jun 5, 2020
jfromaniello
pushed a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Determines the window height using JavaScript and applies height to document root when using the Passwordless UI. This takes into account any window chrome provided by mobile devices.
This is a patch that was already applied to the primary Lock UI, but not passwordless.
Before
After
References
Fixes #1826
Testing
Tested manually using Browserstack + local iOS 11 Pro Simulator.
Checklist