Show the "Can't be blank" message under the password input #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjmcgrath
commented
Jun 9, 2020
| @@ -1210,6 +1210,7 @@ loadingSize = 30px | |||
| .auth0-lock-password-strength | |||
| width 100% | |||
| bottom 41px | |||
| left 0 | |||
There was a problem hiding this comment.
Now the password strength field is position relative to the password input, we have to add left 0 to take the padding for the icon into account (other wise the password strength tooltip would be 40px to the right)
adamjmcgrath
commented
Jun 9, 2020
| @@ -40,8 +40,8 @@ export default class InputWrap extends React.Component { | |||
| <div className={wrapClassName}> | |||
| {iconElement} | |||
| {this.props.children} | |||
| {after} | |||
There was a problem hiding this comment.
The component after is only ever the password strength field. I've made it positioned relative to this div, because it doesn't change height (the outer div does depending on the value of errorTooltip)
adamjmcgrath
commented
Jun 9, 2020
| @@ -61,7 +61,7 @@ export default class PasswordInput extends React.Component { | |||
| <InputWrap | |||
| after={passwordStrength} | |||
| focused={focused} | |||
| invalidHint={policy ? undefined : invalidHint} | |||
There was a problem hiding this comment.
My assumption is that this logic was added because we didn't want to reposition the password strength tooltip if there was an invalid hint.
lbalmaceda
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Show the "Can't be blank" message under the password field when you try and submit a blank password.
Before
After
References
fixes #1721
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist