Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-1756] Remove HTML5 novalidate attribute from Lock form #1890

Merged
merged 3 commits into from
Jun 30, 2020

Conversation

stevehobbsdev
Copy link
Contributor

Changes

This change removes the HTML5 novalidate attribute, preventing the browser
from performing its own native validation and allowing Lock to do its
validation instead.

The native validation prevented users from submitting email addresses such as
"téstiñg.üsêr@example.com", which is a valid value on the Auth0 server side.

References

Raised through internal service desk ticket.

Testing

Tested manually. Cannot test through integration testing as the client-side
native validation does not kick in.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@stevehobbsdev stevehobbsdev requested a review from a team June 30, 2020 10:41
@stevehobbsdev stevehobbsdev added CH: Changed enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature labels Jun 30, 2020
@stevehobbsdev
Copy link
Contributor Author

Build is failing but the fix is in #1889, will rebase once that PR is merged.

lbalmaceda
lbalmaceda previously approved these changes Jun 30, 2020
@stevehobbsdev stevehobbsdev merged commit 3af220c into master Jun 30, 2020
@stevehobbsdev stevehobbsdev added this to the vNext milestone Jun 30, 2020
@stevehobbsdev stevehobbsdev mentioned this pull request Jul 2, 2020
jfromaniello pushed a commit to jfromaniello/auth0-lock that referenced this pull request Jul 23, 2020
* [SDK-1756] Remove HTML5 novalidate attribute from Lock form

* Update snapshot

Co-authored-by: Luciano Balmaceda <balmacedaluciano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants